Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in correlation with new GH Action Permission Changes. #400

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

Tatsinnit
Copy link
Member

These changes are made in correlation with the following changes coming soon in the GH actions permissions. Please take a kind look. ❤️🙏☕️

To start with going with the most safest option with read only permission, for publish we need the write for content. Given this will spread pretty soon lets try this out and I will gradually open similarity changes in other repos I know.

Screenshot 2024-01-22 at 11 41 38 AM

For Sample test if we do content: read (In a separate repo) for publish we will get some error like this which I tested in my fork for other project.

Screenshot 2024-01-22 at 11 27 19 AM

Thank you. ❤️🙏

Signed-off-by: Tatsinnit <Tatsinnit@users.noreply.github.com>
@Tatsinnit Tatsinnit added the enhancement New feature or request label Jan 23, 2024
@Tatsinnit Tatsinnit self-assigned this Jan 23, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b43d04) 65.46% compared to head (20750fd) 65.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #400   +/-   ##
=======================================
  Coverage   65.46%   65.46%           
=======================================
  Files          27       27           
  Lines        1894     1894           
=======================================
  Hits         1240     1240           
  Misses        579      579           
  Partials       75       75           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@weinong weinong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weinong weinong merged commit 8d55d74 into Azure:main Jan 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants